[PATCH] Part 1 for flapping notify tests

[Andrew Bartlett]

On Fri, 2018-08-31 at 15:58 -0700, Jeremy Allison via samba-technical
wrote:
> On Wed, Aug 29, 2018 at 09:14:27AM +1200, Andrew Bartlett wrote:
> > G'Day Jeremy,
> > 
> > Following up from our recent phone call and your gallant offer to
> > assist, here are some notify failures I've seen recently that I would
> > love to see resolved, as they flap reasonably often:
> > 
> > [93(538)/94 at 9m51s] samba3.smb2.notify-inotify(fileserver)
> > smbtorture 4.10.0pre1-DEVELOPERBUILD
> > Using seed 1535488533
> > Testing change notify of a rename with inotify
> > UNEXPECTED(failure): samba3.smb2.notify-inotify.inotify-
> > rename(fileserver)
> > REASON: Exception: Exception: ../source4/torture/smb2/notify.c:2441:
> > status was NT_STATUS_CANCELLED, expected NT_STATUS_OK: smb2_notify_recv
> > failed
> 
> OK, here is the first effort. I'm not 100% sure this is
> a related fix, but this test was leaving the directory
> behind on exit, so this patchset is a needed cleanup
> IMHO.
> 
> Please review and push if happy. It's in gitlab
> test right now.

Thanks for giving this a stab.  This landed in master today as
c86f6c2916c0c87efffe2d5b48f231a073b8c33e

For my part, I've tried to reduce the flapping password_lockout tests,
and have ideas on how to fix the replica_sync tests.  Hopefully between
us we can reduce the all-around frustrating these cause.

Thanks!

Andrew Bartlett
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba