[PATCH] Remove fstring from wb_acct_info

Andrew Bartlett abartlet at samba.org
Wed Oct 31 22:52:22 UTC 2018


On Wed, 2018-10-31 at 15:23 -0700, Jeremy Allison via samba-technical
wrote:
> On Wed, Oct 31, 2018 at 03:19:12PM -0700, Jeremy Allison via samba-technical wrote:
> > 
> > Having said that I can't see any place were acct_desc
> > is used by the caller so I think it's good.
> 
> In case I'm not being clear:
> 
> Reviewed-by: Jeremy Allison <jra at samba.org>
> 
> for the patch, and if Andrew can find his way
> to be happy with it that's a second Team
> reviewer :-).
> 
> Andrew, can I convince you this patch is
> correct ? :-).

Not until the memory lifetimes clearly follow the tree.

Sorry,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list