Some patches for import-lorikeet-heimdal branch

[Isaac Boukris]

On Wed, Oct 10, 2018 at 7:09 AM Andrew Bartlett <abartlet at samba.org> wrote:
>
> On Fri, 2018-09-28 at 21:30 +0530, Isaac Boukris via samba-technical
> wrote:
> > Assuming we are ok with that change of order of methods (capath vs
> > referrals), I'll try to confirm and update the expectation in the
> > torture test.
>
> That is the right approach.

I've made a patch for this, along with some other stuff I found on the
way. Please take a look at:
https://gitlab.com/samba-team/devel/samba/commits/iboukris_lorikeet_import_round_one

$ make test TESTS=samba4.krb5.kdc SAMBA_OPTIONS="-d3" >out.log 2>err.log

$ grep failure before_patch.log |wc -l
1750

$ grep failure after_patch.log |wc -l
1694

$ grep -A1 failure before_patch.log | grep Exception | cut -d ' ' -f4 | sort -u
../source4/torture/krb5/kdc-canon-heimdal.c:1783:
../source4/torture/krb5/kdc-canon-heimdal.c:1950:
../source4/torture/krb5/kdc-canon-heimdal.c:2085:
../source4/torture/krb5/kdc-canon-heimdal.c:2153:
../source4/torture/krb5/kdc-heimdal.c:812:
../source4/torture/krb5/kdc-heimdal.c:824:

$ grep -A1 failure after_patch.log | grep Exception | cut -d ' ' -f4 | sort -u
../source4/torture/krb5/kdc-canon-heimdal.c:1783:
../source4/torture/krb5/kdc-canon-heimdal.c:1950:
../source4/torture/krb5/kdc-canon-heimdal.c:1998:
../source4/torture/krb5/kdc-canon-heimdal.c:2377:
../source4/torture/krb5/kdc-heimdal.c:812:
../source4/torture/krb5/kdc-heimdal.c:824: