[PATCH] Fix nasty vfs_fruit bug 13646

Jeremy Allison jra at samba.org
Wed Oct 31 19:41:54 UTC 2018


On Wed, Oct 31, 2018 at 12:39:41PM -0700, Jeremy Allison via samba-technical wrote:
> 
> Which will return nread == AFP_INFO_SIZE *even
> if the caller asked for *less* (remember, to_read
                                            ^^^^^^^
                                 Should be to_return of course :-)

> is MIN(n, AFP_INFO_SIZE)) !
> 
> This should instead be:
> 
> 		return to_return;
> 
> as that is the amount we just copied into data, and
> may be less than nread.
> 
> If you agree with this fix, LGTM.
> 
> Jeremy.
> 



More information about the samba-technical mailing list