[PATCH] more python patches (unused variables)
nopower at suse.com
Wed Oct 31 16:59:36 UTC 2018
On 28/10/2018 22:11, Douglas Bagnall via samba-technical wrote:
> I thought I was finished, but I found these.
> They are mostly to do with unused variables.
> In review, you might want to consider whether these variables
> *should* have been used, and these patches are heading in the
> wrong direction.
I think the majority of these are either cut'n'paste related or remnants
of debug code, ones I would worry a little about (but not much) would be
> [PATCH 03/16] dbchecker: remove unused variables
> - controls = ["extended_dn:1:1", "show_recycled:1"]
Is there a chance the controls should be used in the following
> if self.do_modify(m, ["show_recycled:1"],
I don't know enough about that to comment more:-(
also err_wrong_default_sd doesn't use sd_old that is passed in
> [PATCH 14/16] python/join: remove unused imports and variables
> record_type = dnsp.DNS_TYPE_A
that one maybe could be used in the call to
'dns_conn.DnssrvEnumRecords2' in the same method, so maybe record_type
should have been used there (with record_type = dnsp.DNS_TYPE_ALL) but
again I have no real clue.
other than that I'd say RB+ from m3. I guess it would be wise to wait a
little bit to see if anyone one else wants to chime in and if nobody
raises anything in the next day or 2 then push the lot :-)
More information about the samba-technical