[PATCH] Fix nasty vfs_fruit bug 13646

[Ralph Böhme]

On Mon, Oct 29, 2018 at 04:36:32PM -0700, Jeremy Allison wrote:
>On Fri, Oct 26, 2018 at 04:59:24PM +0200, Ralph Böhme via samba-technical wrote:
>>
>> thanks!
>>
>> Turned out the order was not really correct as this patchset wasn't rebased
>> onto the other ones.
>>
>> Updated, rebased patchset attached.
>
>One more comment - in the following:
>
>> From 83925fb3b4f8f4d2a9f33b0654801beb3cc47475 Mon Sep 17 00:00:00 2001
>> From: Ralph Boehme <slow at samba.org>
>> Date: Mon, 15 Oct 2018 16:03:03 +0200
>> Subject: [PATCH 08/34] s4:torture/vfs/fruit: update test "rename_dir_openfile"
>>  to work against macOS
>>
>> The test opens a directory twice where the first open didn't allow
>> sharing. No idea why this works against Samba, against macOS the second
>> open got a sharing violation. Obvious fix: add proper sharing.
>
>Don't want to block the patch on this, but can we flag this
>for further investigation inside Samba, I'd like to know
>what is going on here..

I took a another look: this was just caused by different codepaths in the 
torture test based on --option=torture:osx=true|false.

For the Samba case (false above) we didn't close an earlier directory open 
whilst closing it against macOS. I've changed the patch to make sure it closes
the first directory open.

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46