ad-dc-2 python3 problem

[Noel Power]

Hi Tim

On 29/10/2018 22:15, Tim Beale wrote:
> Hi Noel,
>
> Not sure if you've made any progress on this. I took a quick look and
> figured out the samba_spnupdate problem.
>
> The problem is the 'servicePrincipalName' message attributes returned
> from the database are actually byte strings. However, the
> samba_spnupdate script treats these values as regular strings (for
> string comparison, etc). Python-2 just ignores the 'b' prefix, whereas
> Python-3 treats it as a bytes literal.
OMG how could I miss that, I was looking in all the wrong places,
> The attached change fixes the error, however, I'm not sure if we need to
> worry about things like UTF encoding here or not.
>
> I think the spnupdate error was breaking DNS resolution in the testenv.
> No DNS would then break Kerberos, which would cause the login_basics
> test to fail.

yep looks like it, thanks alot

Noel