[PATCH] Remove size limit of client-side parsing of dirsync control

Garming Sam garming at catalyst.net.nz
Tue Oct 30 00:23:58 UTC 2018

Hi metze,

In a domain with 200 cursor entries in the dirsync cookie, while I was
looking at syncing passwords, I noticed that the server failed to get a
valid cookie returned and it turned out that it was truncated by the
client (at 1024 base64 characters or ~670 bytes). Attached is the patch
where I just did the simplest thing to get it to work. I don't know if
we should have further validation, but I didn't know if there were
actual limitations to this cookie, or what's done in Windows either.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dirsync-Allow-arbitrary-length-cookies.patch
Type: text/x-patch
Size: 1293 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181030/d65de7ce/0001-dirsync-Allow-arbitrary-length-cookies.bin>

More information about the samba-technical mailing list