[PR PATCH] Fix compatibility issues with the timespec struct

[Volker Lendecke]

On Fri, Oct 19, 2018 at 08:31:41AM +0000, Github bot account via samba-technical wrote:
> There is a new pull request by joankaradimov against master on the Samba Samba Github repository
> 
> https://github.com/joankaradimov/samba timespec-compatibility
> https://github.com/samba-team/samba/pull/212
> 
> Fix compatibility issues with the timespec struct
> I'm compiling `ffmpeg` with `--enable-libsmbclient`. During the configuration phase I'm getting:
> ```
> ./ffbuild/config.log:/usr/include/samba-4.0/libsmbclient.h:158:18: error: field 'btime_ts' has incomplete type
> ./ffbuild/config.log:/usr/include/samba-4.0/libsmbclient.h:162:18: error: field 'mtime_ts' has incomplete type
> ./ffbuild/config.log:/usr/include/samba-4.0/libsmbclient.h:166:18: error: field 'atime_ts' has incomplete type
> ./ffbuild/config.log:/usr/include/samba-4.0/libsmbclient.h:170:18: error: field 'ctime_ts' has incomplete type
> ```
> 
> The problem appears to be that the `timespec` struct is not defined. Including `time.h` solves the issue. It can be reproduced in 4.9.1, but not in 4.8.

The patch of course looks good, RB+.

> In a somewhat related note - libsmbclient.h currently cannot be used with `--std=c99` because of the dependency on `timespec`.

Is that solved with your patch or isn't it? If not, I'd like to
understand why struct timespec is in conflict with --std=c99. Does c99
not enable timespec in time.h?

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de