[PATCHES] avoid "import *" in Python

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Wed Oct 24 23:17:27 UTC 2018


In Python you can use "from foo import *" to get all the names defined
by foo, including all the imports that foo makes. This is sometimes
handy, but is considered bad form because it makes it hard to know what
names you have and where they came from.

These patches remove some cases of "import *" from our code by importing
the things that are actually used.

In some cases it turns out that hardly anything needed to be imported.
In the other cases, selftesthelpers was involved. Feel free to reject
those patches for the sheer increase in verbosity.

https://gitlab.com/samba-team/devel/samba/pipelines/34091069

Douglas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: import-star.patch
Type: text/x-patch
Size: 7756 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181025/b2dc9ff1/import-star-0001.bin>


More information about the samba-technical mailing list