[PATCH] Fix nasty vfs_fruit bug 13646

Jeremy Allison jra at samba.org
Wed Oct 24 19:09:36 UTC 2018

On Tue, Oct 23, 2018 at 05:54:08PM +0200, Ralph Böhme via samba-technical wrote:
> Hi!
> Attached is a somewhat largish patchset to fix bug 13646.
> It got this big as I'm expanding existing tests and adding a new large one,
> trying very hard to test all possible combinations of resetting the a stream
> on one handle and testing the outcome on the same and different handles.
> At the base this patchset fixes the problem introduced by the patches for
> bug 13441. There I added a change to unlink a stream in the VFS ftruncate
> function if offset=0.
> As SMB_VFS_FTRUNCATE with offset=0 may also be called at create time with
> create dispostion OVERWRITE, this does more bad then good and caused real
> world application problems like MS Excel not being able to save. :/
> Simply reverting the change from bug 13441 was not really an option as that
> would have reintroduced the problems 13441 was trying to fix.
> Hopefully this patchset does a better job. I've therefor added a new large
> test that covers the subtle cases and I've did some manual end-to-end
> testing with Excel, Word, Photoshop and Finder Tags.
> Please review&push if happy. Thanks!
> CI: https://gitlab.com/samba-team/devel/samba/pipelines/34033409
> Oh, and please apply the fruit patchsets in the order of appearance on the list:
> [PATCH] Follow-up fix for bug 13649
> [PATCH] Add optional AppleDouble cleanup to vfs_fruit
> ...this one...

Out at the Linux Foundation Edinburgh show until the end
of the week. I'll try and get to these as soon as I'm
back (and not jet-lagged anymore :-), sorry.


More information about the samba-technical mailing list