[PATCH] avoid strlen(NULL)

Martin Schwenke martin at meltin.net
Thu Oct 18 22:16:38 UTC 2018

On Fri, 19 Oct 2018 10:38:39 +1300, Douglas Bagnall via samba-technical
<samba-technical at lists.samba.org> wrote:

> Yesterday I pushed a little optimisation in ce518f387f9f that introduced
> a possible strlen(NULL).
> It is funny how mistakes you miss in the editor become so blindingly
> obvious when they are sent back to you on a public email list.
> BTW, this strlen was accounting for 95% of the CPU time of a large
> failing join (and about 6% of the time of a successful join, which I
> don't know how to explain).

Reviewed-by: Martin Schwenke <martin at meltin.net>


peace & happiness,

More information about the samba-technical mailing list