Failures in password_lockout: (was: Re: [PATCH] A bugfix (IMHO) for namemap_cache)

[Andrew Bartlett]

On Tue, 2018-10-16 at 16:44 +0200, Volker Lendecke via samba-technical
wrote:
> On Tue, Oct 16, 2018 at 10:58:45AM +0200, Andreas Schneider via samba-technical wrote:
> > You can get it the following way:
> > 
> > Install docker and run:
> > 
> > docker run -ti registry.gitlab.com/samba-team/samba:latest /bin/bash
> > 
> > Then you need to clone the samba git repository with your changes and run the 
> > test.
> > 
> > You can find how to run it in the log of the failed pipeline.
> 
> With a great hint from Alexander this finally worked. You have to mess
> with systemd to get this done: the magic URL is
> 
> https://docs.docker.com/config/daemon/systemd/#httphttps-proxy
> 
> which interestingly was not found by the most popular search engine
> when asking "docker behind proxy". But all of this does not get me any
> further:
> 
> make test TESTS=samba4.ldap.password_lockout
> 
> in the docker environment did work fine. So either something before
> that test kills it in gitlab, or the docker environment does not fully
> represent what is running in the gitlab pipeline.
> 
> I'm officially confused. Next attempt is to run a full "make test" in
> the docker environment. Lets see.

Thanks.  If you can post the error output, I can give a view on the
possible causes.  

I will note this:  The password_lockout tests are timing sensitive. 
The checks about the locked out account (across multiple protocols)
must all complete before the account auto-unlocks. 

This timeout for auto-unlock can be extended, but it makes the whole
test slower, as we have to sleep() that amount of time.

In this case I would consider if:
 - perhaps you have just been unlucky
 - could the cache fix be making things slower?

However I would really need to see the test output to say more.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba