[PATCH] Bug 13653 - dsdb encrypted_secrets: Allow "ldb:// and "mdb://" in key file path

Andrew Bartlett abartlet at samba.org
Tue Oct 16 02:53:57 UTC 2018

On Tue, 2018-10-16 at 15:38 +1300, Gary Lockyer via samba-technical
> Correctly handle "ldb://" and "mdb://" schemes in the file path when
> determining the path for the encrypted secrets key file.
> Fix for https://bugzilla.samba.org/show_bug.cgi?id=13653
> Review appreciated

Except for 
+if "HAVE_LMDB" in config_hash:

(which we always have in selftest and which is a structure we try to
avoid) this looks good!

Just remove that line.

Finally, can you get the random_password into BlackboxTestCase and make
it use a 'proper' RNG (just so we don't have to fix it later for a
static security analysis tool). 

Other than that:
Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

More information about the samba-technical mailing list