[PATCH] A bugfix (IMHO) for namemap_cache

Jeremy Allison jra at samba.org
Mon Oct 15 18:15:26 UTC 2018


On Mon, Oct 15, 2018 at 02:48:58PM +0000, jim via samba-technical wrote:
> Shouldn't these tests be 'expired || state->offline' instead of 
> '!expired ...'?
> This would then match the test you are replacing and the tests you 
> changed in winbindd_cache.c.

No, I don't think so. The code changes look correct to me.

Remember, this is setting 'state->found' which should be
true if the entry has *not* expired, or if the current
state is offline.



More information about the samba-technical mailing list