One hundred python patches
nopower at suse.com
Fri Oct 12 08:01:54 UTC 2018
Reposting due to the fact I sent this already from non-registered
secondary mail account :-/ (problems with work email for me at the moment)
On 12/10/2018 08:14, Noel Power wrote:
> Re: One hundred python patches
> On 12/10/2018 07:04, Alexander Bokovoy via samba-technical wrote:
>> On pe, 12 loka 2018, Douglas Bagnall via samba-technical wrote:
>>> I have about 100 patches to python files here:
>>> They are WIP. Most of them are probably correct, though collectively
>>> they don't like to pass CI.
>> Thanks for this effort, Douglas.
>> May be you can submit them in groups that are smaller and pass the
>> tests? They aren't dependent on each other in most cases.
> yep, please do these in bite sized portions if only to save my sanity
> (another large patchset brewing here.....
> This one currently passes all (*manually*, note: *no* CI job yet)
> 215/215 e.g all pass for
> |PYTHON=python3 make test FAIL_IMMEDIATELY=1
> TESTS='--include-env=none' aka build_samba_none_env|
> |and 109/147 (not all patches for this result pushed to branch yet....
> but will be later today) for|
> |||make test FAIL_IMMEDIATELY=1 TESTS='--include-env=chgdcpass
> --include-env=vampire_2000_dc --include-env=fl2000dc
> --include-env=ad_dc_no_nss --include-env=backupfromdc
> --include-env=restoredc --include-env=renamedc
> --include-env=offlinebackupdc --include-env=labdc ' aka
> |I was intending to try and get these two jobs passing completely
> before going back over the patches and reworking them (they are still
> WIP) However I will just try and get a patchset (and CI job) for
> ||build_samba_none_env (pure-python3) if I fail to get the last
> ad_dc_2 tests passing early next week.|
More information about the samba-technical