[PATCH] memset_s() and talloc_set_secure()

Andrew Bartlett abartlet at samba.org
Thu Oct 11 11:07:40 UTC 2018

On Thu, 2018-10-11 at 12:17 +0200, Andreas Schneider via samba-
technical wrote:
> Hello,
> the attached patch adds memset_s() [1] and talloc_set_secure(). It will make 
> sure that memory is zeroed/erased before freeing to not keep secrets around.

Stepping back a moment, how do you handle talloc_realloc()?

That either needs to be banned or handled to ensure the old memory is
wiped after a memcpy() to new memory (with performance losss). 

(And that will all need tests).

Sorry this is turning into a can of worms, but if we do this we need to
do it completely. 

Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list