Remove more crypto (sha256, sha512, hmac-sha256) (was: Re: [PATCH] Remove lib/crypto/crc32.[ch])

Jeremy Allison jra at
Wed Oct 10 16:18:48 UTC 2018

On Wed, Oct 10, 2018 at 10:17:59PM +1300, Andrew Bartlett via samba-technical wrote:
> On Wed, 2018-10-10 at 10:47 +0200, Andreas Schneider wrote:
> > For other crypto we would need to have an abstraction which either uses 
> > Samba's crypto or GnuTLS.
> That seems to be what is required for AES to keep the acceleration on a
> broad set of hosts.

Just one comment, any patch that removes the existing
Intel AESNI code Netgear created should come along with
benchmarks showing the fileserver code is unaffected
performance-wise when signing/sealing by the change
(by unaffected I mean less than 1-2% performance
drop) otherwise I'm going to strongly NAK :-).

I fought too hard to get that code in to gain us
performance to drop if for build cleanlyness and
convenience :-).


More information about the samba-technical mailing list