[PATCH] Fix AppleDouble conversion in vfs_fruit

[Ralph Böhme]

On Tue, Oct 09, 2018 at 10:43:46AM +0200, Ralph Böhme via samba-technical wrote:
>Hi!
>
>Attached is a patch that fixes AppleDouble conversion in vfs_fruit.
>
>https://bugzilla.samba.org/show_bug.cgi?id=13649
>
>vfs_fruit has a conversion routine to migrate stuff from macOS created 
>AppleDouble files created on shares without a stream module.
>
>Unfortunately the conversion of the mandatory FinderInfo metadata got 
>dependent on the conversion of AppleDouble embodied xattrs. As the 
>latter is only optional, for many AppleDouble files we did not convert 
>FinderInfo.
>
>The patchset is mainly a refactoring of ad_convert() in small 
>digestible pieces, the fix is delivered with the last commit.
>
>CI: https://gitlab.com/samba-team/devel/samba/pipelines/32377745
>
>Manual testing: make test TESTS=vfs.fruit
>
>Please review & push if happy. Thanks!

please hold on, something's fishy. This was passing manual make test vfs.fruit 
whereas it's now failing. Checking...

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46