[PATCH] Fix CTDB recovery record resurrection from inactive nodes and simplify vacuuming (bug #13641)

[Amitay Isaacs]

On Fri, Oct 5, 2018 at 1:49 PM Martin Schwenke via samba-technical
<samba-technical at lists.samba.org> wrote:
>
> When a CTDB node becomes active after being stopped or banned, records
> that have been deleted and vacuumed on other nodes can be resurrected
> from newly active nodes during recovery.  This can be fixed by marking
> volatile databases as invalid when a node becomes inactive and avoiding
> pulling records from invalid databases.
>
> Following this, vacuuming can be simplified by reverting to a 2 phase
> model.  The current 3 phase vacuuming was created to solve the record
> resurrection problem, which is now solved more generally.
>
> All but 1 of the commits here are Amitay's and are posted with my
> Reviewed-by:.  The additional commit by me is a test that demonstrates
> the problem (and confirms the solution) and needs review.
>
> Please review and maybe push...

Pushed to autobuild.

Amitay.