[PATCH] ctdbd_conn: Generalise inaccurate error message

[Volker Lendecke]

On Fri, Oct 05, 2018 at 01:20:14PM +0300, Alexander Bokovoy wrote:
> On pe, 05 loka 2018, Volker Lendecke via samba-technical wrote:
> > On Fri, Oct 05, 2018 at 07:47:42AM +0200, Volker Lendecke wrote:
> > > On Fri, Oct 05, 2018 at 02:26:57PM +1000, Martin Schwenke via samba-technical wrote:
> > > > Seeing:
> > > > 
> > > >   ctdb_read_packet failed: Cannot allocate memory
> > > >   [...,  0] ../source3/lib/ctdbd_conn.c:121(cluster_fatal)
> > > >   cluster fatal event: ctdbd died
> > > > 
> > > > The error is due to a memory allocation failure rather than ctdbd
> > > > dying.  However, the error message makes people wonder why ctdbd died.
> > > 
> > > Pushed, thanks!
> > 
> > This now failed 3 times in a row with
> > 
> > [62(1609)/216 at 17m5s] samba.unittests.kerberos
> > UNEXPECTED(failure): samba.unittests.kerberos.test_krb5_remove_obsolete_keytab_entries_one(none)
> > REASON: Exception: Exception: "user0 at samba.example.comb" != "user0 at samba.example.com"
> > ../source4/auth/tests/kerberos.c:64: error: Failure!
> > 
> > which looks unrelated to me. I'm giving up, sorry.
> I provided a fix to the above problem in a separate thread but it never
> ended up in the tree. Perhaps, autobuilds are failing a lot?

I've pushed that together with Martin's patch. We should add a patch
on top replacing [24] and [6] with []. What do you think?

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de