[PATCH] pyauth: Remove the imessaging_ctx parameter

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Oct 5 10:35:39 UTC 2018


On Wed, Oct 03, 2018 at 10:49:57PM +0300, Alexander Bokovoy via samba-technical wrote:
> From 3b19d979a5fd5201d4048c047239733e58eea70c Mon Sep 17 00:00:00 2001
> From: Alexander Bokovoy <ab at samba.org>
> Date: Wed, 3 Oct 2018 22:48:00 +0300
> Subject: [PATCH] s4/auth/tests: Fix kerberos test string size
> 
> >>> len("user0 at samba.example.com")
> 23
> 
> But the string definition does not take a final '\0' into account.
> 
> Signed-off-by: Alexander Bokovoy <ab at samba.org>
> ---
>  source4/auth/tests/kerberos.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source4/auth/tests/kerberos.c b/source4/auth/tests/kerberos.c
> index 703c8067908..477e26e68de 100644
> --- a/source4/auth/tests/kerberos.c
> +++ b/source4/auth/tests/kerberos.c
> @@ -26,7 +26,7 @@ static void internal_obsolete_keytab_test(int num_principals, int num_kvnos,
>  
>  	int i,j;
>  	char princ_name[6] = "user0";
> -	char expect_princ_name[23] = "user0 at samba.example.com";
> +	char expect_princ_name[24] = "user0 at samba.example.com";

This looks good to me, RB+. But why specify the length at all? I'd
rather do that as

char expect_princ_name[] = "user0 at samba.example.com";

likewise for the princ_name[] above.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de



More information about the samba-technical mailing list