[PATCH] make nsswitch and libwbclient thread safe

Jeremy Allison jra at samba.org
Thu Oct 4 22:58:30 UTC 2018

On Thu, Oct 04, 2018 at 09:04:16PM +0200, Volker Lendecke via samba-technical wrote:
> On Thu, Oct 04, 2018 at 04:36:25PM +0200, Ralph Wuerthner via samba-technical wrote:
> > Please see attached patchset to make nsswitch & libwbclient thread safe.
> > 
> > Currently nsswitch & libwbclient share a common, global context when
> > communicating to winbindd. Threaded applications submitting requests in
> > parallel via nsswitch & libwbclient to winbindd can fail because of the
> > simplistic design of the communication protocol.
> > 
> > With the patch applied, access to the global libwbclient context is
> > serialized by a mutex, similar to the mutex used in winbind_nss_linux.c.
> Looks good to me. One question: Do you have a test to excercise the
> failure and the succeeding behaviour?

Also looks a good change to me (RB+). Volker, do you want
to push or wait for a test ?


More information about the samba-technical mailing list