[PATCH] pyauth: Remove the imessaging_ctx parameter

[Alexander Bokovoy]

On ke, 03 loka 2018, Noel Power via samba-technical wrote:
> On 03/10/2018 10:37, Noel Power via samba-technical wrote:
> > RB+
> > 
> > On 02/10/2018 21:01, Gary Lockyer via samba-technical wrote:
> > > Remove the imessaging_ctx parameter from the pyauth constructor. The
> > > pyauth code expects this to be a imessaging_context struct.  The
> > > imessaging code returns a wrapper structure that contains the
> > > imessaging_context and the talloc context it's allocated on.  As no code
> > > uses this, and to save others a wasted afternoon I've removed the
> > > parameter.  Could I get a review? CI run results
> > > https://gitlab.com/catalyst-samba/samba/pipelines/31618803
> > > 
> > > Thanks
> > > Gary
> > > 
> > 
> > 
> Unfortunately can't get this past autobuild, tried this patch with & without
> Douglas's 'popt_common_creds: actually use the ignore_missing_conf flag'
> Autobuild failed numberous time for me with.  The failure seems unrelated to
> the change, I've run the same on CI
> https://gitlab.com/samba-team/devel/samba/pipelines/31918098 and the
> 'build_samba_nonenv' tests pass fine
> 
> UNEXPECTED(failure): samba.unittests.kerberos.test_krb5_remove_obsolete_keytab_entries_one(none)
> REASON: Exception: Exception:"user0 at samba.example.comb"  !="user0 at samba.example.com"
> ../source4/auth/tests/kerberos.c:64: error: Failure!
I think we have off-by-one in the test:

        char expect_princ_name[23] = "user0 at samba.example.com";

>>> len("user0 at samba.example.com")
23

The storage does not take the remaining '\0' into account.



> 
> FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
> 
> 

-- 
/ Alexander Bokovoy
-------------- next part --------------
>From 3b19d979a5fd5201d4048c047239733e58eea70c Mon Sep 17 00:00:00 2001
From: Alexander Bokovoy <ab at samba.org>
Date: Wed, 3 Oct 2018 22:48:00 +0300
Subject: [PATCH] s4/auth/tests: Fix kerberos test string size

>>> len("user0 at samba.example.com")
23

But the string definition does not take a final '\0' into account.

Signed-off-by: Alexander Bokovoy <ab at samba.org>
---
 source4/auth/tests/kerberos.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source4/auth/tests/kerberos.c b/source4/auth/tests/kerberos.c
index 703c8067908..477e26e68de 100644
--- a/source4/auth/tests/kerberos.c
+++ b/source4/auth/tests/kerberos.c
@@ -26,7 +26,7 @@ static void internal_obsolete_keytab_test(int num_principals, int num_kvnos,
 
 	int i,j;
 	char princ_name[6] = "user0";
-	char expect_princ_name[23] = "user0 at samba.example.com";
+	char expect_princ_name[24] = "user0 at samba.example.com";
 	bool found_previous;
 	const char *error_str;
 
-- 
2.17.1