[PATCH] pyauth: Remove the imessaging_ctx parameter
nopower at suse.com
Wed Oct 3 19:22:15 UTC 2018
On 03/10/2018 10:37, Noel Power via samba-technical wrote:
> On 02/10/2018 21:01, Gary Lockyer via samba-technical wrote:
>> Remove the imessaging_ctx parameter from the pyauth constructor. The
>> pyauth code expects this to be a imessaging_context struct. The
>> imessaging code returns a wrapper structure that contains the
>> imessaging_context and the talloc context it's allocated on. As no code
>> uses this, and to save others a wasted afternoon I've removed the
>> parameter. Could I get a review? CI run results
Unfortunately can't get this past autobuild, tried this patch with &
without Douglas's 'popt_common_creds: actually use the
ignore_missing_conf flag' Autobuild failed numberous time for me with.
The failure seems unrelated to the change, I've run the same on CI
https://gitlab.com/samba-team/devel/samba/pipelines/31918098 and the
'build_samba_nonenv' tests pass fine
REASON: Exception: Exception:"user0 at samba.example.comb" !="user0 at samba.example.com"
../source4/auth/tests/kerberos.c:64: error: Failure!
FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
More information about the samba-technical