[Patches] SESSION_EXPIRED on encrypted sessions (bug #13624)

[Stefan Metzmacher]

Hi Jeremy,

>> here're patches which demonstrate bug #13624 ( STATUS_SESSION_EXPIRED
>> error is returned unencrypted, if the request was encrypted)
>> and fix it.
>>
>> Here's a merge request
>> https://gitlab.com/samba-team/samba/merge_requests/81
>> and the related pipeline:
>> https://gitlab.com/samba-team/devel/samba/pipelines/31492348
>>
>> Please review and push:-)
> 
> RB+ good catch. Did you see this at the plugfest or at
> the Redmond event ?

No, it was found by a customer.

> Took me a while to go through the codepaths to make
> sure the:
> 
>  @@ -2544,10 +2553,6 @@ NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req)
>   				      session_info->info->domain_name);
>   	}
>   
>  -	if (req->was_encrypted || encryption_desired) {
>  -		req->do_encryption = true;
>  -	}
>  -
>   	if (req->session) {
> 
> Hunk was OK, but I'm pretty sure it is :-).

Thanks!

> Eventually we might want to decorate the
> bools related to encryption and signing
> in this function to make everything very
> clear for reviewers, but I guess this isn't
> that patch :-).

Feel free to propose something on top.

Thanks!
metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181002/b6be3c8e/signature.sig>