[PATCH] Another flapping python 3 test
metze at samba.org
Mon Oct 1 07:32:04 UTC 2018
the problem is that an unexpected "error" is generated,
knownfail can only catch unexpected "failures"...
With python this typically happens if we don't catch expections,
ok = False
ok = True
except SkipTest as e:
KCCTests.test_verify() needs to catch the
samba.kcc.graph_utils.GraphError exception and generate
a self.failureException exception, which typically happens with
the self.assert*() functions.
Am 29.09.2018 um 04:00 schrieb Douglas Bagnall via samba-technical:
> On 29/09/18 6:04 AM, Andreas Schneider wrote:
>> On Thursday, 20 September 2018 03:43:18 CEST Douglas Bagnall via samba-
>> technical wrote:
>>> This is another Python 3 test that is flapping on sn-devel.
>>> The test is still being run in Python 2 and never fails there. It also
>>> presumably works OK in Python 3, but it doesn't like doing both at the
>>> same time.
>>> The trouble started with this recent patch:
>>> b2665d569e35957aa2433e010175ed1fe361ee7b s4/selftest: enable samba.tests.kcc
>>> for py3
>>> but rather than go backwards on that, let's put it to the side for
>>> now. What we care about now is that the file parses and runs as both
>>> pythons, and the test passes. Running both versions at once is not a
>>> long term goal.
>> Douglas, that rule doesn't seem to work!
> Oh. It is *this* line that has the filterable name:
>> [67(594)/75 at 42m9s] samba.tests.kcc.python3(vampire_dc)
> Please try with this patch.
>> REASON: Exception: Exception: Traceback (most recent call last):
>> File "bin/python/samba/tests/kcc/__init__.py", line 80, in test_verify
>> File "bin/python/samba/kcc/__init__.py", line 2659, in run
>> File "bin/python/samba/kcc/__init__.py", line 2513, in plot_all_connections
>> File "bin/python/samba/kcc/graph_utils.py", line 334, in verify_and_dot
>> for p, e, doc in errors)))
>> samba.kcc.graph_utils.GraphError: The 'dsa_final CN=NTDS
>> Name,CN=Sites,CN=Configuration,DC=samba,DC=example,DC=com' graph lacks the
>> following properties:
>> connected: the graph is not connected, as the following vertices are
>> That's now the 5ths time in a row that I hit that with my pipeline:
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: OpenPGP digital signature
More information about the samba-technical