[PATCH] Fix for XDR Backend of NFS4ACL_XATTR module to get it working with NFS4.0 ACL Spec

Sandeep Nashikkar snashikkar at commvault.com
Fri Nov 30 11:51:16 UTC 2018

On Wed, Nov 28, 2018 at 02:37 AM IST Ralph Böhme wrote:

>attached is an updated patchset with a bunch of fixes above the previous version.

> This one passes make test TESTS=raw.acls against shares with the new module format "nfs" for versions 4.0 and 4.1.

> Currently running full CI: https://gitlab.com/samba-team/devel/samba/pipelines/38130330

> To get make test working I had to fix an older bug
> https://bugzilla.samba.org/show_bug.cgi?id=12164

> The fix for this bug is part of the attached patchset.

> -slow

Hi Ralph, 

Thanks a lot for the patchset. I tried it with our setup and with following options:
        nfs4acl_xattr:encoding = nfs
        nfs4acl_xattr:validate_mode = yes
        nfs4acl_xattr:nfs4_id_numeric = yes
        nfs4acl_xattr:xattr_name = system.nfs4_acl

I could test the basic get and set ACL operations over SMB client on windows. Since this patchset has more functionality with respect to compatibility with various versions, we are good to go with this one. I think the approach is similar to adding "xdr40" encoding in my latest patchset with some more changes. 

Now, the important question is, when do we plan to push the commit in master and which version of Samba release we can expect to have these changes?
We also have tight schedules for deliverables due to customer requirements and it will help if we get to know the timelines. 


********************************Legal Disclaimer********************************
"This communication may contain confidential and privileged material for the
sole use of the intended recipient. Any unauthorized review, use or distribution
by others is strictly prohibited. If you have received the message by mistake,
please advise the sender by reply email and delete the message. We may process
information in the email header of business emails sent and received by us
(including the names of recipient and sender, date and time of the email) for
the purposes of evaluating our existing or prospective business relationship.
The lawful basis we rely on for this processing is our legitimate interests. For
more information about how we use personal information please read our privacy
policy https://www.commvault.com/privacy-policy. Thank you."

More information about the samba-technical mailing list