[PATCH] NTLM tests ported to Python3
abartlet at samba.org
Thu Nov 29 17:26:01 UTC 2018
On Thu, 2018-11-29 at 12:26 +0100, Samuel Cabrero via samba-technical
> with the idea of extending the NTLM tests I have started by porting the
> current mix of bash and python scripts to python3.
> These tests looks to me more stable now using python's subprocess
> module, before that I was getting broken pipe errors from time to time.
> Please review and push if you agree.
Can you push to the shared CI repo and open a gitlab merge request with
this? It looks like my day is going to be pretty busy (it is public
that there is a regression on the CNAME security issue) and I don't
want to forget it.
But I do want to encourage you, at first glace it looks great to have
this done more properly in pure python.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical