[PATCH] #ifdef code cleanup
Andreas Schneider
asn at samba.org
Thu Nov 29 07:38:06 UTC 2018
On Thursday, 29 November 2018 08:00:39 CET Martin Schwenke wrote:
> On Thu, 29 Nov 2018 07:36:40 +0100, Andreas Schneider via
>
> samba-technical <samba-technical at lists.samba.org> wrote:
> > On Wednesday, 28 November 2018 20:52:22 CET Gary Lockyer wrote:
> > > Looks good to me RB+
> > > Pushing to autobuild.
> >
> > Thanks Gary!!
>
> It looks like something (probably commit
> 63a48e64871cbfa36c4f9686a36a951711135114) broke the FreeBSD build:
>
> [3442/3889] Compiling source3/winbindd/winbindd.c
> ../../source3/winbindd/winbindd.c:1615:47: error: use of undeclared
> identifier 'environ' setproctitle_init(argc, discard_const(argv), environ);
> ^
> It looks to be as simple as environ not being defined in replace.h, but
> I'm not completely sure if the fix is as simple as I think it
> is... and my brain has melted by the end of the day. :-)
According to the manpage, this is provided by unistd.h. So the attached patch
should fix this. Could you please check?
Thanks,
Andreas
--
Andreas Schneider asn at samba.org
Samba Team www.samba.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-replace-Correctly-check-for-extern-char-environ-in-u.patch
Type: text/x-patch
Size: 2069 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181129/4418f188/0001-replace-Correctly-check-for-extern-char-environ-in-u.bin>
More information about the samba-technical
mailing list