[PATCH] Reduce debug level for testparm (was Re: Wrong debug level for testparm in manual page?)

[Anoop C S]

On Fri, 2018-11-23 at 14:18 +0530, Anoop C S via samba-technical wrote:
> On Tue, 2018-11-13 at 17:52 +0100, Björn Baumbach via samba-technical wrote:
> > Hi!
> > 
> > On 11/13/18 10:38 AM, Anoop C S via samba-technical wrote:
> > > Manual page for testparm[1] mentions default debug level as 1. But we explicitly set to 2
> > > inside
> > > source3/utils/testparm.c. Which side needs correction?
> > > 
> > > From manual page perspective we use a common stdarg.client.debug entity for mentioning the
> > > debug
> > > level in few manual page definitions. Whereas in code I see a solid comment stating that debug
> > > level
> > > being set to 2.
> > 
> > I know this exists since decades, but in my opinion testparm should not
> > overwrite the log level, which is specified in the smb.conf.
> > 
> > Users use the testparm tool to verify or dump the configuration. It can
> > confuse users if testparm prints different values than specified in the
> > configuration.
> > 
> > If it's used and needed to reduce the debug output, we should reduce the
> > level, because even with level 2 there is some debug output like e.g.
> > 'Registered MSG_REQ_POOL_USAGE'.
> 
> Attached patch reduces testparm's debug level to 1. Reviews are appreciated.

CI - https://gitlab.com/samba-team/devel/samba/pipelines/38063533

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-testparm-Reduce-debug-level-to-1.patch
Type: text/x-patch
Size: 1033 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181129/c63198ef/0001-s3-testparm-Reduce-debug-level-to-1.bin>