[PATCH] Improve a debug message

Jeremy Allison jra at samba.org
Tue Nov 27 17:09:32 UTC 2018


On Tue, Nov 27, 2018 at 09:40:55AM +0100, Volker Lendecke via samba-technical wrote:
> Hi!
> 
> Review appreciated!

Obvious goodness :-). LGTM, RB+ and pushed.

> -- 
> Besuchen Sie die verinice.XP 2019 in Berlin!
> Anwenderkonferenz für Informationssicherheit
> 26.-28. Februar 2019 - im Hotel Radisson Blu
> Info & Anmeldung hier: http://veriniceXP.org
> 
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de, mailto:kontakt at sernet.de

> From 17056607bc8faa386ff5c89977773bfea83522b7 Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Mon, 26 Nov 2018 16:21:16 +0100
> Subject: [PATCH] notifyd: Improve a debug message
> 
> Signed-off-by: Volker Lendecke <vl at samba.org>
> ---
>  source3/smbd/notifyd/notifyd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/source3/smbd/notifyd/notifyd.c b/source3/smbd/notifyd/notifyd.c
> index e4e5c785472..811ada969fb 100644
> --- a/source3/smbd/notifyd/notifyd.c
> +++ b/source3/smbd/notifyd/notifyd.c
> @@ -469,8 +469,8 @@ static bool notifyd_apply_rec_change(
>  				       notifyd_sys_callback, msg_ctx,
>  				       &instance->sys_watch);
>  		if (ret != 0) {
> -			DEBUG(1, ("%s: inotify_watch returned %s\n",
> -				  __func__, strerror(errno)));
> +			DBG_WARNING("sys_notify_watch for [%s] returned %s\n",
> +				    path, strerror(errno));
>  		}
>  	}
>  
> -- 
> 2.11.0
> 




More information about the samba-technical mailing list