[PATCH] Some for credentials_krb5.c

[Jeremy Allison]

On Tue, Nov 27, 2018 at 08:52:02AM +0100, Volker Lendecke via samba-technical wrote:
> On Tue, Nov 27, 2018 at 04:33:37PM +1300, Andrew Bartlett via samba-technical wrote:
> > On Thu, 2018-11-22 at 11:01 +0100, Volker Lendecke wrote:
> > > Hi, Andrew!
> > > 
> > > Attached find some patches for credentials_krb5.c. In particular
> > > 
> > > [PATCH 3/8] credentials: Fix set_ccache with empty creds cache
> > > 
> > > is the one that triggered this. I did not understand the real meaning
> > > of commit bb2f7e3aee7e9b8 and decided to propose something that makes
> > > it clearer to me.
> > > 
> > > It survived gitlab:
> > > 
> > > https://gitlab.com/samba-team/devel/samba/pipelines/37456362
> > > 
> > > What do you think?
> > > 
> > 
> > Thanks Volker.  I indeed totally missed this while being heads-down in
> > the security release, oops!
> > 
> > However I'm stuck, I can't get the patch to apply to master.  I get:
> > 
> > $ git reset --hard origin/master
> > 
> > $ git am /tmp/vl-patch.txt
> 
> git am -3 does it for me. I am not in the gitlab business yet to the
> level that is required these days to get your attention. So ditch the
> patch.
> 
> Sorry for the noise,

Volker, this isn't a helpful attitude for collaborating with others.

Please stop responding to any minor hiccup by requesting the patch
be withdrawn. It's not a responsible or professional attitude that
we're trying to encourage in the project.

Doing this means it's almost impossible to review your patches,
as any feedback or minor issue gets this kind of response from
you.

Please don't do this.

Jeremy.