[PATCH] Two dependent bugfixes for VSS bugs 13455 and 13688

Ralph Böhme slow at samba.org
Fri Nov 23 20:00:57 UTC 2018

On Fri, Nov 23, 2018 at 12:53:02PM -0800, Jeremy Allison wrote:
>On Fri, Nov 23, 2018 at 12:45:47PM -0800, Jeremy Allison via samba-technical wrote:
>> Ralph, I thin [PATCH 09/10] s3:smbd: GMT token handling on paths: prefix, don't append
>> is incorrect.
>> We used to do this, but found it breaks pathnames with a MS-DFS
>> prefix (such as \\server\share\path).
>> If you haven't already, please check this code against a
>> server set up with MS-DFS pathnames.
>> If you don't have time before then, let's talk when I'm back in at
>> work on Monday.
>> >
>> > The ':' after "foor" sets stream_started to true, then the '\' after
>> > "stream" triggers the error.
>> >
>> > Fix: prepend the GMT token to the path, that's what we're later doing in
>> > canonicalize_snapshot_path() anyway. For the above example that results
>Note that canonicalize_snapshot_path() is called *after* any MS-DFS
>processing is done, which is why it's safe to do that there.
>I think the correct fix here is to search in the SMB2 create
>code for a ':' character and if found, insert the @GMT token
>before that, otherwise append as we're currently doing.
>This will leave the MS-DFS processing working I think.

ok, thanks, I'll recheck. This is a real mess! :)


Ralph Boehme, Samba Team                https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG-Fingerprint   FAE2C6088A24252051C559E4AA1E9B7126399E46

More information about the samba-technical mailing list