[PATCH] #ifdef code cleanup

[Andrew Bartlett]

On Fri, 2018-11-23 at 10:06 +1300, Andrew Bartlett via samba-technical
wrote:
> On Thu, 2018-11-22 at 21:32 +0100, Andreas Schneider wrote:
> > On Thursday, 22 November 2018 19:36:57 CET Andrew Bartlett via samba-technical 
> > wrote:
> > > On Thu, 2018-11-22 at 09:30 +0100, Andreas Schneider via samba-
> > > 
> > > technical wrote:
> > > > Hi,
> > > > 
> > > > attached is a patchset which cleans up checking for config.h defines
> > > > correctly.
> > > > 
> > > > Please review. Push if OK.
> > > 
> > > This looks good, but honestly I'm a bit nervous.  Any chance you have
> > > done a build somehow forcing -E into the gcc line and compared the
> > > results before/after?
> > 
> > This is mostly from CFLAGS="-Wundef"
> 
> Sure, it's not the detection method I'm worried about, it is that large
> patch sets like this can easily slip in typo or similar and cause the
> condition to no longer match.  
> 
> A way to guard against that is to demonstrate that the build produces
> the same output with and without the patch.
> 
> When I make big changes to our selftest system I ensure that the same
> tests (or if different, I can account for the difference) still get
> printed in the output stream, to ensure we don't silently miss tests.  
> 
> Likewise I'm pretty sure I did checking of the config.h results during
> the waf upgrade. 
> 
> Perhaps build with eg CC="my-cc.sh" that compiles with gcc -E and then
> again with a full gcc, to get at the CPP output?

I tried and failed to build that way with the attached.  No idea why it
doesn't work.  So this isn't a reasonable request.  If someone else can
eyeball the whole series and check it is correct, I'll be happy.

Sorry,

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gcc-E
Type: text/x-python
Size: 440 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181123/ce339687/gcc-E.py>