[PATCH] Some fixes detected by Undefined Sanitizer

[Andrew Bartlett]

On Thu, 2018-11-22 at 17:07 +0100, Andreas Schneider via samba-
technical wrote:
> On Thursday, 22 November 2018 16:26:45 CET Andreas Schneider via samba-
> technical wrote:
> > On Wednesday, 21 November 2018 11:20:44 CET Andreas Schneider via samba-
> > 
> > technical wrote:
> > > Hi,
> > > 
> > > see attached. Review and comments are welcome. Please push if OK.
> > 
> > Here is an updated patchset with more patches. I have more in the queue, but
> > I can tell you, there be dragons!
> > 
> > https://gitlab.com/samba-team/devel/samba/pipelines/37563706
> 
> I've removed one patch which fixed some tdb stuff. This needs more fixing by 
> the callers first.
> 
> New pipeline:
> https://gitlab.com/samba-team/devel/samba/pipelines/37566650
> 

I agree.  Changing asn.1 code is to tempt big, fiery dragons.  Can you
have Jeremy look at that one?

But I do want to say a big Thank You for looking into this stuff, this
is really important, and we should get a GitLab job set up that
triggers this long-term.

A next area of research might be how to use some of the attributes in:

https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html 

seems like it might help a lot, such as the alignment and malloc-like
attributes.  Adding those to talloc() et al could be quite interesting.

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba