|PATCH] dsdb group audit test : Fix string compares

[Andrew Bartlett]

On Mon, 2018-11-19 at 11:48 +1300, Gary Lockyer via samba-technical
wrote:
> With the actual patch attached this time.
> 

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

It is in autobuild, and seems to be past the tfork() test, so
hopefully!

Andrew Bartlett

> 
> On 19/11/18 09:11, Gary Lockyer via samba-technical wrote:
> > New patch set with requested changes.
> > 
> > CI run: https://gitlab.com/samba-team/devel/samba/pipelines/37033885
> > 
> > Thanks
> > 
> > Gary
> > 
> > On 15/11/18 21:24, Andreas Schneider wrote:
> > > On Wednesday, 14 November 2018 21:38:25 CET Gary Lockyer via samba-technical 
> > > wrote:
> > > > Replace the uses of:
> > > >     strncmp(expected, value, strlen(expected))
> > > > With:
> > > >     strcmp(expected, value)
> > > 
> > > I've you're already changing it, please do:
> > > 
> > > int cmp;
> > > 
> > > cmp = strcmp("groupChange", value);
> > > if (cmp != 0)
> > > ...
> > > 
> > > for both hunks ...
> > > 
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 862 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181120/fe202b53/signature.sig>