[Patches] waf and other build fixes

Stefan Metzmacher metze at samba.org
Mon Nov 19 22:36:57 UTC 2018


Am 19.11.18 um 23:22 schrieb Andrew Bartlett via samba-technical:
> On Tue, 2018-11-20 at 09:22 +1300, Andrew Bartlett via samba-technical
> wrote:
>> On Fri, 2018-11-16 at 17:06 +0100, Stefan Metzmacher via samba-
>> technical wrote:
>>> Hi,
>>>
>>> here're some patches which fix some regressions introduced by the change
>>> to waf 2.0.8.
>>>
>>> Please review and push:-)
>>>
>>> A pipeline was successful here:
>>> https://gitlab.com/samba-team/devel/samba/pipelines/36776640
>>
>> G'Day metze!
>>
>> Can I add your signed-off-by on 
>>
>> commit 9fa38efe7a00cdb38445b94d2604625fc2a91287
>> Author: Stefan Metzmacher <metze at samba.org>
>> Date:   Thu Nov 15 11:41:07 2018 +0100
>>
>>     wafsamba: remove the need of BuildContext.bdir
>>
>> So I can review and push this?

Sure.

>> Otherwise: 
>>
>> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
>>
>> Thanks,
>>
>> Andrew Bartlett
> 
> Oddly I can't get this to build locally, I get:
> 
> source4/librpc/gen_ndr/tables.c:7:47: fatal error:
> default/librpc/gen_ndr/ndr_wzcsvc.h: No such file or directory
>  #include "default/librpc/gen_ndr/ndr_wzcsvc.h"
>                                                ^
> compilation terminated.
> 
> Any idea what is going on, I've already tried cleaning out ./bin

You mean removing bin/ completely?

This looks like source4/librpc/gen_ndr/tables.c from before the patchset.

Can you reproduce this after a git clean -xdf?

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181119/7f8eb32f/signature.sig>


More information about the samba-technical mailing list