[PATCH] Log client process name in winbindd

Jeremy Allison jra at samba.org
Fri Nov 9 20:33:00 UTC 2018


On Fri, Nov 09, 2018 at 12:21:48PM -0800, Jeremy Allison via samba-technical wrote:
> On Fri, Nov 09, 2018 at 05:06:51PM +0100, Andreas Schneider wrote:
> > On Friday, 9 November 2018 01:01:05 CET Jeremy Allison wrote:
> > > Yeah, OK. But I get nervous when I see
> > > 
> > > 	snprintf(buf, len, XXXX...)
> > > 
> > > calls with no checks. Maybe just make them
> > > into:
> > > 
> > > 	(void)snprintf(buf, len, XXXX...)
> > > 
> > > so it's explicit we're ignoring the return ?
> > 
> > I hope the attached patchset addresses your concerns.
> 
> Yep, thanks Andreas ! RB+ and pushed.

Arg. Fails ABI check. Can you merge the following
fix and re-post for review ?

Thanks,

Jeremy.
-------------- next part --------------
From 2582872011e4f3184c7e16e8cf487716643c2ba2 Mon Sep 17 00:00:00 2001
From: Jeremy Allison <jra at samba.org>
Date: Fri, 9 Nov 2018 12:32:07 -0800
Subject: [PATCH] Squashme: Fix wbclient ABI.

Signed-off-by: Jeremy Allison <jra at samba.org>
---
 nsswitch/libwbclient/wbclient.h | 3 ++-
 nsswitch/libwbclient/wscript    | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/nsswitch/libwbclient/wbclient.h b/nsswitch/libwbclient/wbclient.h
index 341a733dd6c..05cf8a14b80 100644
--- a/nsswitch/libwbclient/wbclient.h
+++ b/nsswitch/libwbclient/wbclient.h
@@ -76,9 +76,10 @@ const char *wbcErrorString(wbcErr error);
  *  0.13: Added wbcCtxUnixIdsToSids and wbcUnixIdsToSids
  *  0.14: Added "authoritative" to wbcAuthErrorInfo
  *        Added WBC_SID_NAME_LABEL
+ *  0.15: Added wbcSetClientProcessName()
  **/
 #define WBCLIENT_MAJOR_VERSION 0
-#define WBCLIENT_MINOR_VERSION 14
+#define WBCLIENT_MINOR_VERSION 15
 #define WBCLIENT_VENDOR_VERSION "Samba libwbclient"
 struct wbcLibraryDetails {
 	uint16_t major_version;
diff --git a/nsswitch/libwbclient/wscript b/nsswitch/libwbclient/wscript
index 70fed6fc2ed..7bb612d670a 100644
--- a/nsswitch/libwbclient/wscript
+++ b/nsswitch/libwbclient/wscript
@@ -3,7 +3,7 @@
 from waflib import Options, Logs
 
 # Remember to also update wbclient.h
-VERSION="0.14"
+VERSION="0.15"
 
 # It may be useful at some point to allow Samba to build against a
 # system libwbclient, such as the one provided by Likewise.  To to
-- 
2.19.1.930.g4563a0d9d0-goog



More information about the samba-technical mailing list