[RFC PATCH] unbreak mit kdc
Alexander Bokovoy
ab at samba.org
Fri Nov 9 08:22:51 UTC 2018
On ke, 07 marras 2018, Andreas Schneider via samba-technical wrote:
> On Wednesday, 7 November 2018 13:27:22 CET Philipp Gesang wrote:
> > -<| Quoting Andreas Schneider <asn at samba.org>, on Tuesday, 2018-11-06
> > 12:43:20 PM |>-
> > > On Tuesday, 6 November 2018 09:24:00 CET Philipp Gesang via
> > > samba-technical
> > >
> > > wrote:
> > > > > For the failing init of krb5 ctx, kdm5 and kdb I would return
> > > > > NT_STATUS_INTERNAL_ERROR.
> > > > >
> > > > > For the failing connection to samdb I would return:
> > > > > NT_STATUS_CONNECTION_INVALID or NT_STATUS_CONNECTION_ABORTED
> > > >
> > > > Ok. See attached v2.
> > >
> > > For
> > >
> > > "KDC: no network interfaces configured"
> > >
> > > shouldn't we return NT_STATUS_NOINTERFACE?
> >
> > That would have to be reflected in kdc-heimdal.c as well. It
> > currently has:
> >
> > 286 load_interface_list(task, task->lp_ctx, &ifaces);
> > 287
> > 288 if (iface_list_count(ifaces) == 0) {
> > 289 task_server_terminate(task, "kdc: no network
> > interfaces configured", false); 290 return
> > NT_STATUS_UNSUCCESSFUL;
> > 291 }
> >
> > Maybe in a separate patch?
> >
> > Philipp
>
> OK, RB+ by me, anyone else who can look at the patch?
OK with me too. RB+.
Andreas, can you please push?
--
/ Alexander Bokovoy
More information about the samba-technical
mailing list