[RFC PATCH] unbreak mit kdc

[Philipp Gesang]

-<| Quoting Andreas Schneider <asn at samba.org>, on Tuesday, 2018-11-06 12:43:20 PM |>-
> On Tuesday, 6 November 2018 09:24:00 CET Philipp Gesang via samba-technical 
> wrote:
> > > For the failing init of krb5 ctx, kdm5 and kdb I would return
> > > NT_STATUS_INTERNAL_ERROR.
> > > 
> > > For the failing connection to samdb I would return:
> > > NT_STATUS_CONNECTION_INVALID or NT_STATUS_CONNECTION_ABORTED
> > 
> > Ok. See attached v2.
> 
> For
> 
> "KDC: no network interfaces configured"
> 
> shouldn't we return NT_STATUS_NOINTERFACE?

That would have to be reflected in kdc-heimdal.c as well. It
currently has:

    286         load_interface_list(task, task->lp_ctx, &ifaces);
    287 
    288         if (iface_list_count(ifaces) == 0) {
    289                 task_server_terminate(task, "kdc: no network interfaces configured", false);
    290                 return NT_STATUS_UNSUCCESSFUL;
    291         }

Maybe in a separate patch?

Philipp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181107/2e500f75/signature.sig>