[PATCH] CTDB configuration clean-ups

Martin Schwenke martin at meltin.net
Tue Nov 6 00:47:30 UTC 2018

Hi Amitay,

On Tue, 6 Nov 2018 10:05:10 +1100, Amitay Isaacs
<amitay at gmail.com> wrote:

> On Mon, Nov 5, 2018 at 11:25 AM Martin Schwenke via samba-technical
> <samba-technical at lists.samba.org> wrote:
> >
> > This patch set drops ad hoc usage of CTDB_SOCKET and CTDB_PIDFILE
> > environment variables.  Instead, common path handling is now used
> > throughout the code.  As documented in tests/README, this
> > means that compile-time defaults are used unless CTDB_TEST_MODE and
> > CTDB_BASE are set, in which case locations relative to CTDB_BASE are
> > used.
> >
> > However, note that the first commit adds an exception for CTDB_SOCKET to
> > the common path handling.  This is used when the caller asks for the
> > socket path for "ctdbd" (and when CTDB_SOCKET is set).
> >
> > Please review and maybe push...  
> In the patch "ctdb-tests: Use path_socket() in dummy client",  there
> is no need to set default options.sockpath using
> talloc_autofree_context().
> Let the default be NULL.  If there is no socket argument, use existing
> mem_ctx to set up the default sockpath.

Yeah, sounds good.  Done.

I've also dropped the other use of talloc_autofree_context(), as

New version attached...

peace & happiness,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctdb-config.patch
Type: text/x-patch
Size: 17979 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181106/2e7de485/ctdb-config.bin>

More information about the samba-technical mailing list