[RFC PATCH] unbreak mit kdc

[Andreas Schneider]

On Monday, 5 November 2018 16:53:49 CET Philipp Gesang via samba-technical 
wrote:
> Hey guys,

Hi Philipp,

> devel master is broken right now in an MIT KRB5 build.

ouch this only produces a warning and not an error.

I think we need:

-Werror=incompatible-pointer-types

for --picky-developer at least!
 
> Please review the attached patch which restores compilation for
> me. Some inserts have been tagged “XXX” because frankly I have
> no idea what status code would be appropriate. Suggestions would
> be very much appreciated.

For the failing init of krb5 ctx, kdm5 and kdb I would return 
NT_STATUS_INTERNAL_ERROR.

For the failing connection to samdb I would return: 
NT_STATUS_CONNECTION_INVALID or NT_STATUS_CONNECTION_ABORTED


	Andreas

-- 
Andreas Schneider                      asn at samba.org
Samba Team                             www.samba.org
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D