xfstest recent results
Steve French
smfrench at gmail.com
Sat Nov 3 18:57:23 UTC 2018
Strangely enough this seems to be a Samba server bug (just reproduced
on jra's 4.10-pre git tree as well - so still broken in current Samba)
Updating ctime doesn't persist now that we do compounding (works to
Windows, but not Samba)
Simple to reproduce - just run this executable (which simply gets
timestamps, sets ctime, and gets timestamps - super simple).
xfstests-dev/src/t_futimens
Works on mount to Windows but not mounts to Samba.
wireshark shows the expected - compounded setinfo setting
FILE_ALL_INFO (only ctime) and then compounded queryinfo FILE_ALL_INFO
next shows the ctime unchanged
C
On Fri, Nov 2, 2018 at 10:46 PM Steve French <smfrench at gmail.com> wrote:
>
> oddly test 221 seems to fail without most recent changes - maybe
> something in the VFS changed and broke it? or did it always fail?
> On Fri, Nov 2, 2018 at 10:43 PM Steve French <smfrench at gmail.com> wrote:
> >
> > Seen any issues with xfstests?
> >
> > Saw this on current for-next (may have been around for a while)
> > test 221 failed (and I can repeat it)
> > generic/221 1s ... - output mismatch (see
> > /home/sfrench/xfstests-dev/results//generic/221.out.bad)
> > --- tests/generic/221.out 2018-03-24 14:12:39.747668134 -0500
> > +++ /home/sfrench/xfstests-dev/results//generic/221.out.bad
> > 2018-11-02 22:20:42.684152693 -0500
> > @@ -1,2 +1,3 @@
> > QA output created by 221
> > Silence is golden.
> > +failed to update ctime!
> > ...
> > (Run 'diff -u tests/generic/221.out
> > /home/sfrench/xfstests-dev/results//generic/221.out.bad' to see the
> > entire diff)
> >
> > Did that used to fail?
> >
> > and some concerns with test 13
> > [ 689.790450] run fstests generic/013 at 2018-11-02 22:03:36
> > [ 690.838933] ==================================================================
> > [ 690.839030] BUG: KASAN: slab-out-of-bounds in
> > id_mode_to_cifs_acl+0x342/0x1fe0 [cifs]
> > [ 690.839041] Read of size 256 at addr ffff880716ebd900 by task fsstress/7644
> >
> > [ 690.839058] CPU: 6 PID: 7644 Comm: fsstress Not tainted 4.19.0+ #50
> > [ 690.839062] Hardware name: LENOVO 20HJS01E00/20HJS01E00, BIOS
> > N1UET71W (1.45 ) 07/18/2018
> > [ 690.839065] Call Trace:
> > [ 690.839078] dump_stack+0xd6/0x185
> > [ 690.839086] ? show_regs_print_info+0xb/0xb
> > [ 690.839093] ? printk+0x9c/0xc3
> > [ 690.839099] ? kmsg_dump_rewind_nolock+0xe4/0xe4
> > [ 690.839108] print_address_description+0x6f/0x270
> > [ 690.839115] kasan_report+0x263/0x390
> > [ 690.839192] ? id_mode_to_cifs_acl+0x342/0x1fe0 [cifs]
> > [ 690.839203] check_memory_region+0x137/0x190
> > [ 690.839209] memcpy+0x23/0x50
> > [ 690.839286] id_mode_to_cifs_acl+0x342/0x1fe0 [cifs]
> > [ 690.839366] ? cifs_acl_to_fattr+0x1ce0/0x1ce0 [cifs]
> > [ 690.839440] cifs_setattr+0x15b2/0x29a0 [cifs]
> > [ 690.839511] ? cifs_getattr+0x760/0x760 [cifs]
> > [ 690.839518] ? save_stack+0xa3/0xd0
> > [ 690.839523] ? save_stack+0x43/0xd0
> > [ 690.839528] ? __kasan_slab_free+0x137/0x190
> > [ 690.839534] ? kasan_slab_free+0xe/0x10
> > [ 690.839541] ? kmem_cache_free+0xad/0x240
> > [ 690.839548] ? putname+0xbc/0xf0
> > [ 690.839554] ? filename_lookup+0x2d3/0x5c0
> > [ 690.839560] ? user_path_at_empty+0x36/0x40
> > [ 690.839567] ? do_fchownat+0xd1/0x1b0
> > [ 690.839574] ? __x64_sys_lchown+0x7e/0xc0
> > [ 690.839581] ? do_syscall_64+0x153/0x460
> > [ 690.839589] ? entry_SYSCALL_64_after_hwframe+0x44/0xa9
> > [ 690.839596] ? d_exact_alias+0x730/0x730
> > [ 690.839603] ? __save_stack_trace+0x92/0x100
> > [ 690.839612] ? get_device_system_crosststamp+0xa00/0xa00
> > [ 690.839620] ? apparmor_file_receive+0xe0/0xe0
> > [ 690.839626] ? terminate_walk+0x1df/0x470
> > [ 690.839634] ? make_kprojid+0x20/0x20
> > [ 690.839642] ? __vfs_getxattr+0x30/0xa0
> > [ 690.839649] ? evm_inode_setattr+0x5c/0x130
> > [ 690.839659] notify_change+0x8f7/0xe20
> > [ 690.839668] ? setattr_prepare+0x600/0x600
> > [ 690.839673] ? down_write+0x66/0x100
> > [ 690.839683] chown_common+0x4ec/0x650
> > [ 690.839689] ? chown_common+0x4ec/0x650
> > [ 690.839698] ? chmod_common+0x5a0/0x5a0
> > [ 690.839704] ? __mnt_want_write+0x1e3/0x3f0
> > [ 690.839712] ? rcu_cleanup_dead_rnp+0x190/0x190
> > [ 690.839724] do_fchownat+0x15e/0x1b0
> > [ 690.839732] ? __ia32_sys_chmod+0x80/0x80
> > [ 690.839740] ? __do_munmap+0xc90/0xc90
> > [ 690.839747] ? __bpf_trace_sys_enter+0x10/0x10
> > [ 690.839756] __x64_sys_lchown+0x7e/0xc0
> > [ 690.839764] do_syscall_64+0x153/0x460
> > [ 690.839771] ? syscall_return_slowpath+0x2f0/0x2f0
> > [ 690.839779] ? do_page_fault+0x97/0x410
> > [ 690.839786] ? kasan_check_read+0x11/0x20
> > [ 690.839794] ? __do_page_fault+0xa50/0xa50
> > [ 690.839802] ? post_copy_siginfo_from_user.isra.17.part.18+0x150/0x150
> > [ 690.839810] ? perf_trace_sys_enter+0x10d0/0x10d0
> > [ 690.839820] entry_SYSCALL_64_after_hwframe+0x44/0xa9
> > [ 690.839826] RIP: 0033:0x7fc04fc96447
> > [ 690.839835] Code: 73 01 c3 48 8b 0d 41 9a 2d 00 f7 d8 64 89 01 48
> > 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 5e 00 00
> > 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 11 9a 2d 00 f7 d8 64 89
> > 01 48
> > [ 690.839839] RSP: 002b:00007ffe008f06e8 EFLAGS: 00000246 ORIG_RAX:
> > 000000000000005e
> > [ 690.839846] RAX: ffffffffffffffda RBX: 0000000000000005 RCX: 00007fc04fc96447
> > [ 690.839850] RDX: 0000000000000005 RSI: 0000000000000006 RDI: 0000558ccfd416a0
> > [ 690.839854] RBP: 00007ffe008f0860 R08: 000000000000006a R09: 0000000000000000
> > [ 690.839857] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000006
> > [ 690.839861] R13: 0000000000000005 R14: 00007ffe008f0956 R15: 0000558ccf6e0430
> >
> > [ 690.839876] Allocated by task 7644:
> > [ 690.839884] save_stack+0x43/0xd0
> > [ 690.839889] kasan_kmalloc+0xad/0xe0
> > [ 690.839895] __kmalloc+0x132/0x270
> > [ 690.839971] query_info+0x85a/0xdd0 [cifs]
> > [ 690.840045] SMB2_query_acl+0x5c/0xa0 [cifs]
> > [ 690.840119] get_smb2_acl_by_path+0x782/0x1150 [cifs]
> > [ 690.840192] get_smb2_acl+0x75/0x90 [cifs]
> > [ 690.840265] id_mode_to_cifs_acl+0x23a/0x1fe0 [cifs]
> > [ 690.840335] cifs_setattr+0x15b2/0x29a0 [cifs]
> > [ 690.840342] notify_change+0x8f7/0xe20
> > [ 690.840348] chown_common+0x4ec/0x650
> > [ 690.840354] do_fchownat+0x15e/0x1b0
> > [ 690.840360] __x64_sys_lchown+0x7e/0xc0
> > [ 690.840366] do_syscall_64+0x153/0x460
> > [ 690.840372] entry_SYSCALL_64_after_hwframe+0x44/0xa9
> >
> > [ 690.840380] Freed by task 3088:
> > [ 690.840387] save_stack+0x43/0xd0
> > [ 690.840392] __kasan_slab_free+0x137/0x190
> > [ 690.840397] kasan_slab_free+0xe/0x10
> > [ 690.840403] kfree+0xa9/0x200
> > [ 690.840410] kvfree+0x51/0x70
> > [ 690.840416] getxattr+0x17b/0x260
> > [ 690.840422] path_getxattr+0xee/0x160
> > [ 690.840428] __x64_sys_getxattr+0x9d/0x100
> > [ 690.840434] do_syscall_64+0x153/0x460
> > [ 690.840439] entry_SYSCALL_64_after_hwframe+0x44/0xa9
> >
> > [ 690.840449] The buggy address belongs to the object at ffff880716ebd900
> > which belongs to the cache kmalloc-192 of size 192
> > [ 690.840460] The buggy address is located 0 bytes inside of
> > 192-byte region [ffff880716ebd900, ffff880716ebd9c0)
> > [ 690.840467] The buggy address belongs to the page:
> > [ 690.840476] page:ffffea001c5baf00 count:1 mapcount:0
> > mapping:ffff880814c0f100 index:0x0 compound_mapcount: 0
> > [ 690.840487] flags: 0x17ffffc0010200(slab|head)
> > [ 690.840499] raw: 0017ffffc0010200 ffffea001cf54580 0000000800000008
> > ffff880814c0f100
> > [ 690.840509] raw: 0000000000000000 0000000080200020 00000001ffffffff
> > 0000000000000000
> > [ 690.840514] page dumped because: kasan: bad access detected
> >
> > [ 690.840523] Memory state around the buggy address:
> > [ 690.840531] ffff880716ebd880: fb fb fb fb fb fb fb fb fc fc fc fc
> > fc fc fc fc
> > [ 690.840538] ffff880716ebd900: 00 00 00 00 00 00 00 00 00 00 00 00
> > 00 00 00 00
> > [ 690.840545] >ffff880716ebd980: 00 00 00 fc fc fc fc fc fc fc fc fc
> > fc fc fc fc
> > [ 690.840550] ^
> > [ 690.840557] ffff880716ebda00: fb fb fb fb fb fb fb fb fb fb fb fb
> > fb fb fb fb
> > [ 690.840564] ffff880716ebda80: fb fb fb fb fb fb fb fb fc fc fc fc
> > fc fc fc fc
> > [ 690.840569] ==================================================================
> > [ 690.840574] Disabling lock debugging due to kernel taint
> >
> >
> > It passed, and rerunning it passed with no serious warnings (other
> > than 'server overflowed credits'
> > --
> > Thanks,
> >
> > Steve
>
>
>
> --
> Thanks,
>
> Steve
--
Thanks,
Steve
More information about the samba-technical
mailing list