[PATCH] Cache SAMR QueryDisplayInfo, EnumDomainGroups and EnumDomainUsers

[Matthias Dieter Wallnöfer]

Nice work Gary, but this introduces some signed/unsigned integer
mix-ups, to which we should pay more attention than in the past.

Please find the three occurrences which I would change into "unsigned"
(I know it's confusing that the LDB API ldb_* works with "unsigned" and
the SAMDB one with plain "int" since it returns also non-success codes).

Matthias

Gary Lockyer via samba-technical wrote:
> static NTSTATUS load_guid_cache(
> +	struct samr_guid_cache *cache,
> +	struct samr_domain_state *d_state,
> +	int ldb_cnt,
^^^
> +	struct ldb_message **res)
> +{
> +	NTSTATUS status = NT_STATUS_OK;
> +	int i;
^^^
>  
>  /*
>    samr_Connect
> @@ -384,6 +439,7 @@ static NTSTATUS dcesrv_samr_OpenDomain(struct dcesrv_call_state *dce_call, TALLO
>  	const char * const dom_attrs[] = { "cn", NULL};
>  	struct ldb_message **dom_msgs;
>  	int ret;
> +	int i;
^^^


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181103/257f362e/signature.sig>