[PATCH] Remove fstring from wb_acct_info

[Andrew Bartlett]

On Sun, 2018-11-04 at 07:03 +1300, Andrew Bartlett via samba-technical
wrote:
> On Sat, 2018-11-03 at 09:29 +0100, Volker Lendecke wrote:
> > 
> > On Fri, Nov 02, 2018 at 01:52:40PM +1300, Andrew Bartlett wrote:
> > > 
> > > 
> > > On the member server it does that, in winbindd_ads.  However on
> > > the
> > > DC
> > > winbindd_passdb was removed by:
> > > 
> > > commit e1c4b5bbe91b0f2e0abf4e1ddfcd9a7232b12fc8
> > > Author: Andreas Schneider <asn at samba.org>
> > > Date:   Wed Jun 9 16:44:02 2010 +0200
> > > 
> > >     s3-winbind: Replace the passdb backend with a samr/lsa based
> > > backend.
> > > 
> > > So we go via SAMR EnumDomainUsers rather than direct to the LDB.
> > > 
> > > In any case, it seems there is a fair bit more to optimise here.
> > Hmm. Then I don't get what pdb_dsdb is supposed to do. Don't
> > bother,
> > I
> > can find that out if I need to, but it confuses me :-)
> I'm happy to explain that bit:
> 
> It backs the source3 command line tools to allow a consistent user
> experience, as well as enables the classicupgrade tool.

I should note that, like much of Samba, pdb_samba_dsdb is also used for
other things and in other places, many quite critical (in winbind to
take over idmap for example).  

However the above is a good headline view.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba