[RFC] Fix SMB2 aio cancelling
jra at samba.org
Fri Nov 2 20:53:14 UTC 2018
On Wed, Oct 31, 2018 at 10:37:36AM +0100, Ralph Böhme via samba-technical wrote:
> On Mon, Oct 29, 2018 at 10:13:12AM +0100, Ralph Böhme via samba-technical wrote:
> > On Sun, Oct 28, 2018 at 08:04:16PM +0100, Ralph Böhme via samba-technical wrote:
> > > CI: https://gitlab.com/samba-team/devel/samba/pipelines/34610466
> > failed in the ntvfs, forgot to disable the test there.
> > Updated patchset attached.
> > CI: https://gitlab.com/samba-team/devel/samba/pipelines/34651035
> updated patchset attached after feedback from Volker.
> Volker, I've applied your squashes and removed the revert. Instead I added a
> new commit on-top that removes the now unneeded (and possibly confusing) fsp
> NULL check. This commit is not needed for the fixing the bug, so we could
> make it a master only thing, but I think it would be worthwhile including
> CI: https://gitlab.com/samba-team/devel/samba/pipelines/34935883
LGTM. RB+ and pushed - thanks !
More information about the samba-technical