python/samba/ms_forest_updates_markdown.py (was Re: [PATCH] remove "ExistingBackend"...)
nopower at suse.com
Fri Nov 2 10:07:31 UTC 2018
On 01/11/2018 20:49, Douglas Bagnall wrote:
> hi Noel,
>> so... for the above it is possible that save_array could be called with
>> None, maybe this should be an error ?
>> Or we could always create a temp out_dict at the top of
>> read_ms_markdown. I don't think it makes sense to default out_dict in
>> save_array (and passing None to save_array *should* be an error and fail
>> imo) Thoughts ?
> I mostly think we should stop looking. This particular read_ms_markdown
> function is never called with the out_folder option outside of the "if
> __name__ == '__main__'" block, and it only ever has to parse one file
> (source4/setup/adprep/WindowsServerDocs/Forest-Wide-Updates.md). We can
> let it be if it seems to work.
Fair enough :-) RB+ again :-)
More information about the samba-technical