[PATCH] Remove fstring from wb_acct_info

[Andrew Bartlett]

On Thu, 2018-11-01 at 22:15 +0100, Volker Lendecke via samba-technical
wrote:
> On Fri, Nov 02, 2018 at 08:36:22AM +1300, Andrew Bartlett via samba-technical wrote:
> > On Thu, 2018-11-01 at 20:25 +0100, Volker Lendecke wrote:
> > > On Fri, Nov 02, 2018 at 06:34:18AM +1300, Andrew Bartlett wrote:
> > > > 
> > > > Despite everything, our users still want 'getent group' to work,
> > > > and
> > > > similar built-in things like cd ~<tab> to expand to a list of home
> > > > directories.
> > > 
> > > We have the "winbind enum users/groups = no" default for quite a
> > > while
> > > now, and I haven't heard many complaints. Is that really that
> > > important?
> > 
> > Our users seem to think so, clearly they have just been turning it back
> > on again or else this woudln't have come up.
> > 
> > Specifically, I had a customer happily pay us to make the AD DC side of
> > it more efficient (it would re-poll the whole list in the SAMR server
> > for each page).  Gary did that work and the patch should be on the list
> > soon.
> 
> Why does winbind use the samr server for this? Shouldn't that be ldap?

On the member server it does that, in winbindd_ads.  However on the DC
winbindd_passdb was removed by:

commit e1c4b5bbe91b0f2e0abf4e1ddfcd9a7232b12fc8
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jun 9 16:44:02 2010 +0200

    s3-winbind: Replace the passdb backend with a samr/lsa based
backend.

So we go via SAMR EnumDomainUsers rather than direct to the LDB.

In any case, it seems there is a fair bit more to optimise here.

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba