[PATCH] Remove fstring from wb_acct_info

Andrew Bartlett abartlet at samba.org
Thu Nov 1 19:36:22 UTC 2018


On Thu, 2018-11-01 at 20:25 +0100, Volker Lendecke wrote:
> On Fri, Nov 02, 2018 at 06:34:18AM +1300, Andrew Bartlett wrote:
> > 
> > Despite everything, our users still want 'getent group' to work,
> > and
> > similar built-in things like cd ~<tab> to expand to a list of home
> > directories.
> We have the "winbind enum users/groups = no" default for quite a
> while
> now, and I haven't heard many complaints. Is that really that
> important?

Our users seem to think so, clearly they have just been turning it back
on again or else this woudln't have come up.

Specifically, I had a customer happily pay us to make the AD DC side of
it more efficient (it would re-poll the whole list in the SAMR server
for each page).  Gary did that work and the patch should be on the list
soon.

> If so, we definitely need to work on that code. We have to make it a
> lot more fine-grained, fetching smaller pieces.

That might be a good idea.  

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list